From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4ea1::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms12 with LMTPS id cMNeMV/0zGHEYQAAsNZ9tg (envelope-from ); Wed, 29 Dec 2021 23:50:55 +0000 Received: from out0.migadu.com ([2001:41d0:2:267::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 6OZSLl/0zGHBFgAAG6o9tA (envelope-from ); Thu, 30 Dec 2021 00:50:55 +0100 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1640821855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=36vFu5EMiQlEFYY9tOWHKlKFXloQlo9GzdNr+JHu2wc=; b=cwKYvxEHbBgR5aGfcmd+R35ss/I4UK9/svJexna49SkX/uelfWMnI+u85tP0njeYmLyB5I +s67FxNVfzB7yXvk3xaRgsk4lzBEwcPzH2aKfk0GENWkzfW0bOtyajPhTmXeV9jxg2/QEW JLHRo5esqx1IHDPIebveqZNygCnh1cXPsTmfbQ7CSBomkXTK51lAUVrXL0Zw9jWTaQBWWl xamT2XrUgSJBuCoc2ztUMRL0/uTMBaLPacaM57PuqoRTHKKqtO7bQxNNlz0tz9VFrjoAJd uoWHZDDC4uI70tCByVJiv1Jr7B5LLcH7fcxvKo5QE27iINIKn6LWuuXWnUPmYg== From: Kyle Meyer To: piem@inbox.kyleam.com Subject: [RFC PATCH 01/14] am: Give better name to default piem-am-read-worktree-function value Date: Wed, 29 Dec 2021 18:50:23 -0500 Message-Id: <20211229235036.372313-2-kyle@kyleam.com> In-Reply-To: <20211229235036.372313-1-kyle@kyleam.com> References: <20211229235036.372313-1-kyle@kyleam.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: kyleam.com X-TUID: sn6PWYf7XsqU piem-am-read-worktree isn't a good name because it provide any information to distinguish this function from any other function used for piem-am-read-worktree-function. --- piem.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/piem.el b/piem.el index b839942e..9e5b0622 100644 --- a/piem.el +++ b/piem.el @@ -192,7 +192,8 @@ (defcustom piem-am-create-worktree nil "Whether to create a dedicated worktree for applying patches." :type 'boolean) -(defcustom piem-am-read-worktree-function #'piem-am-read-worktree +(defcustom piem-am-read-worktree-function + #'piem-am-read-worktree-sibling-named-by-branch "Function that reads a to-be-created worktree from the user. This function is called with two arguments, the directory of the code repository that the worktree will be created from and the @@ -890,7 +891,7 @@ (defun piem-name-branch-who-what-v (info) (defvar piem-am-args (list "--scissors" "--3way")) -(defun piem-am-read-worktree (coderepo branch) +(defun piem-am-read-worktree-sibling-named-by-branch (coderepo branch) "Read a worktree to create for applying patches. This function is intended to be used as a value of `piem-am-read-worktree-function'. The worktree directory is -- 2.34.0