From: Leo <sourcehut@relevant-information.com>
To: piem@inbox.kyleam.com
Cc: Leo <sourcehut@relevant-information.com>
Subject: [PATCH v4] Add user option for specifying path to notmuch-extract-patch
Date: Tue, 21 Dec 2021 20:15:27 +0100 [thread overview]
Message-ID: <20211221191527.11819-1-sourcehut@relevant-information.com> (raw)
In-Reply-To: <87bl1fx0sx.fsf@kyleam.com>
`notmuch-extract-patch` might not be available on PATH. This can be the
case if the package wasn't installed through the distro package manager.
---
piem-notmuch.el | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/piem-notmuch.el b/piem-notmuch.el
index b48cf70..34231a5 100644
--- a/piem-notmuch.el
+++ b/piem-notmuch.el
@@ -38,6 +38,10 @@ (defgroup piem-notmuch nil
"Notmuch integration for piem."
:group 'piem)
+(defcustom piem-notmuch-extract-patch-executable "notmuch-extract-patch"
+ "Which notmuch-extract-patch executable to use."
+ :type 'string)
+
(defmacro piem-notmuch--with-current-message (&rest body)
(declare (indent 0) (debug (body)))
(let ((rv (make-symbol "rv")))
@@ -120,8 +124,7 @@ (defun piem-notmuch-extract-patch-am-ready-mbox ()
(mm-dissect-buffer))) 0))
(let ((thread-id notmuch-show-thread-id))
(lambda ()
- (if-let ((cmd (executable-find "notmuch-extract-patch"))
- (tid
+ (if-let ((tid
;; Copied from mailscripts.el
;;
;; If `notmuch-show' was called with a notmuch query rather
@@ -134,7 +137,7 @@ (defun piem-notmuch-extract-patch-am-ready-mbox ()
(if (string= (substring thread-id 0 7) "thread:")
thread-id
(concat "thread:{" thread-id "}"))))
- (call-process cmd nil t nil
+ (call-process piem-notmuch-extract-patch-executable nil t nil
tid)
(user-error "The executable notmuch-extract-patch was not found"))))))
base-commit: 3e5535304519c31453ec12037fcd33a4b4095a51
--
2.34.1
next prev parent reply other threads:[~2021-12-21 19:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 15:09 [PATCH v2] Use notmuch-extract-patch if available leo
2021-12-15 5:16 ` Kyle Meyer
2021-12-15 5:22 ` Kyle Meyer
2021-12-16 19:32 ` [PATCH v3 1/2] Support preparing am-ready mbox via notmuch-extract-patch sourcehut
2021-12-16 19:32 ` [PATCH v3 2/2] Add user option for specifying path to notmuch-extract-patch sourcehut
2021-12-17 5:22 ` Kyle Meyer
2021-12-21 19:15 ` Leo [this message]
2021-12-24 18:31 ` [PATCH v4] " Kyle Meyer
2021-12-17 5:15 ` [PATCH v3 1/2] Support preparing am-ready mbox via notmuch-extract-patch Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://git.kyleam.com/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211221191527.11819-1-sourcehut@relevant-information.com \
--to=sourcehut@relevant-information.com \
--cc=piem@inbox.kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.kyleam.com/piem/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).