discussion and development of piem
 help / color / mirror / code / Atom feed
* [PATCH 0/2] piem-use-magit tweaks
@ 2021-05-22 20:39 Kyle Meyer
  2021-05-22 20:39 ` [PATCH 1/2] piem-use-magit: Reword docstring to clarify scope Kyle Meyer
  2021-05-22 20:39 ` [PATCH 2/2] piem-use-magit: Unconditionally set to t Kyle Meyer
  0 siblings, 2 replies; 3+ messages in thread
From: Kyle Meyer @ 2021-05-22 20:39 UTC (permalink / raw)
  To: piem

  [1/2] piem-use-magit: Reword docstring to clarify scope
  [2/2] piem-use-magit: Unconditionally set to t

 Documentation/piem.texi | 9 ++++-----
 piem.el                 | 4 ++--
 2 files changed, 6 insertions(+), 7 deletions(-)


base-commit: 2333819ee6b632909ba7333eb61be1653f5d8203
-- 
2.31.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] piem-use-magit: Reword docstring to clarify scope
  2021-05-22 20:39 [PATCH 0/2] piem-use-magit tweaks Kyle Meyer
@ 2021-05-22 20:39 ` Kyle Meyer
  2021-05-22 20:39 ` [PATCH 2/2] piem-use-magit: Unconditionally set to t Kyle Meyer
  1 sibling, 0 replies; 3+ messages in thread
From: Kyle Meyer @ 2021-05-22 20:39 UTC (permalink / raw)
  To: piem

This option isn't really about using Magit wherever possible, but, as
the manual already states, using Magit for some user-facing
operations.
---
 piem.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/piem.el b/piem.el
index 78536f1..780df00 100644
--- a/piem.el
+++ b/piem.el
@@ -140,7 +140,7 @@ (defcustom piem-git-executable
   :type 'string)
 
 (defcustom piem-use-magit (featurep 'magit)
-  "Whether to use Magit where possible."
+  "Whether to use Magit for some user-facing operations."
   :type 'boolean)
 
 (defcustom piem-default-branch-function
-- 
2.31.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] piem-use-magit: Unconditionally set to t
  2021-05-22 20:39 [PATCH 0/2] piem-use-magit tweaks Kyle Meyer
  2021-05-22 20:39 ` [PATCH 1/2] piem-use-magit: Reword docstring to clarify scope Kyle Meyer
@ 2021-05-22 20:39 ` Kyle Meyer
  1 sibling, 0 replies; 3+ messages in thread
From: Kyle Meyer @ 2021-05-22 20:39 UTC (permalink / raw)
  To: piem

When piem is loaded, piem-use-magit is enabled if Magit has already
been loaded.  This approach is potentially confusing: a user may want
to use Magit, be happy that it seems to just work, and then confused
when it doesn't work in some later session where loading Magit happens
to not be triggered before loading piem.

All the relevant sites have fboundp guards (and those are cheap), so
there's no advantage to disabling this if Magit isn't enabled at load
time.  Set piem-use-magit to t by default.
---
 Documentation/piem.texi | 9 ++++-----
 piem.el                 | 2 +-
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/Documentation/piem.texi b/Documentation/piem.texi
index 0f5235c..ca6a97b 100644
--- a/Documentation/piem.texi
+++ b/Documentation/piem.texi
@@ -265,11 +265,10 @@ Applying patches contained in a message
 
 @cindex magit
 @vindex piem-use-magit
-When piem loads, it detects whether Magit is loaded and sets
-@code{piem-use-magit} accordingly.  If that option is non-nil, piem uses
-Magit for some operations, particularly those that are user-facing.
-This includes jumping to the Magit status buffer for a code repository
-after applying a patch.
+If that option is non-nil and Magit is loaded, piem uses Magit for some
+operations, particularly those that are user-facing.  This includes
+jumping to the Magit status buffer for a code repository after applying
+a patch.
 
 @findex piem-am-ready-mbox
 Note that the @code{piem-am} command works only for buffers from which
diff --git a/piem.el b/piem.el
index 780df00..c273138 100644
--- a/piem.el
+++ b/piem.el
@@ -139,7 +139,7 @@ (defcustom piem-git-executable
   "Which git executable to use."
   :type 'string)
 
-(defcustom piem-use-magit (featurep 'magit)
+(defcustom piem-use-magit t
   "Whether to use Magit for some user-facing operations."
   :type 'boolean)
 
-- 
2.31.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-22 20:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-22 20:39 [PATCH 0/2] piem-use-magit tweaks Kyle Meyer
2021-05-22 20:39 ` [PATCH 1/2] piem-use-magit: Reword docstring to clarify scope Kyle Meyer
2021-05-22 20:39 ` [PATCH 2/2] piem-use-magit: Unconditionally set to t Kyle Meyer

discussion and development of piem

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.kyleam.com/piem/0 piem/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 piem piem/ https://inbox.kyleam.com/piem \
		piem@inbox.kyleam.com
	public-inbox-index piem

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.emacs.piem


code repositories for project(s) associated with this inbox:

	https://git.kyleam.com/piem/

AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git