discussion and development of piem
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: piem@inbox.kyleam.com
Cc: Xinglu Chen <public@yoctocell.xyz>
Subject: [PATCH 3/5] piem-copy-mid-url: Add support for browsing url
Date: Sun,  7 Feb 2021 02:57:36 -0500	[thread overview]
Message-ID: <20210207075738.8752-4-kyle@kyleam.com> (raw)
In-Reply-To: <20210207075738.8752-1-kyle@kyleam.com>

I find the notmuch-show-stash-mlarchive-link-and-go command useful.
It's like notmuch-show-stash-mlarchive-link but calls browse-url on
the copied URL.

Make piem-copy-mid-url do the same when given a prefix argument.
 piem.el | 23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/piem.el b/piem.el
index 0ed288a..5a646c5 100644
--- a/piem.el
+++ b/piem.el
@@ -37,6 +37,7 @@
 ;;; Code:
+(require 'browse-url)
 (require 'cl-lib)
 (require 'mail-extr)
 (require 'message)
@@ -467,15 +468,19 @@ (defun piem-mid-url (mid &optional inbox)
                     (or inbox "current buffer"))))
    (piem-escape-mid mid)))
-(defun piem-copy-mid-url ()
-  "Copy public-inbox URL for the current buffer's message."
-  (interactive)
-  (kill-new
-   (message "%s"
-            (piem-mid-url
-             (or (piem-mid)
-                 (user-error "No message ID found for the current buffer"))
-             (piem-inbox)))))
+(defun piem-copy-mid-url (&optional browse)
+  "Copy public-inbox URL for the current buffer's message.
+With prefix argument BROWSE, call `browse-url' on the URL
+  (interactive "P")
+  (let ((url (piem-mid-url
+              (or (piem-mid)
+                  (user-error "No message ID found for the current buffer"))
+              (piem-inbox))))
+    (prog1
+        (kill-new (message "%s" url))
+      (when browse
+        (browse-url url)))))
 ;;;; Download helpers

  parent reply	other threads:[~2021-02-07  7:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-07  7:57 [PATCH 0/5] New command for copying public-inbox URLs Kyle Meyer
2021-02-07  7:57 ` [PATCH 1/5] piem: Add helper to construct message ID link Kyle Meyer
2021-02-07  7:57 ` [PATCH 2/5] piem-dispatch: Add command for copying public-inbox URLs Kyle Meyer
2021-02-07  7:57 ` Kyle Meyer [this message]
2021-02-07  7:57 ` [PATCH 4/5] piem-copy-mid-url: Allow overriding browse-url-browser-function Kyle Meyer
2021-02-07  7:57 ` [PATCH 5/5] manual: Add section on "copy public-inbox link" functionality Kyle Meyer
2021-02-07 12:38 ` [PATCH 0/5] New command for copying public-inbox URLs Xinglu Chen
2021-02-07 16:57   ` Kyle Meyer
2021-02-07 17:35     ` Kyle Meyer
2021-02-07 20:25       ` Xinglu Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://git.kyleam.com/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210207075738.8752-4-kyle@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=piem@inbox.kyleam.com \
    --cc=public@yoctocell.xyz \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).