discussion and development of piem
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: piem@inbox.kyleam.com
Subject: [PATCH 2/4] gnus, notmuch: Share "attachment is patch?" logic
Date: Sun, 22 Nov 2020 15:46:07 -0500	[thread overview]
Message-ID: <20201122204609.12604-3-kyle@kyleam.com> (raw)
In-Reply-To: <20201122204609.12604-1-kyle@kyleam.com>

This will gain another condition.  Avoid repeating it across two
 piem-gnus.el    | 4 ++--
 piem-notmuch.el | 4 ++--
 piem.el         | 5 +++++
 3 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/piem-gnus.el b/piem-gnus.el
index 237eeb1..c1551ce 100644
--- a/piem-gnus.el
+++ b/piem-gnus.el
@@ -69,8 +69,8 @@ (defun piem-gnus-am-ready-mbox ()
              (delq nil
                    (mapcar (lambda (handle)
                              (and (listp handle)
-                                  (member (mm-handle-media-type handle)
-                                          '("text/x-diff" "text/x-patch"))
+                                  (piem-am-patch-attachment-p
+                                   (mm-handle-media-type handle))
                                     (mm-display-inline handle)
diff --git a/piem-notmuch.el b/piem-notmuch.el
index cd3153a..ccfae75 100644
--- a/piem-notmuch.el
+++ b/piem-notmuch.el
@@ -91,8 +91,8 @@ (defun piem-notmuch-am-ready-mbox ()
          (let ((patches
                 (delq nil
                       (mapcar (lambda (part)
-                                (and (member (plist-get part :content-type)
-                                             '("text/x-diff" "text/x-patch"))
+                                (and (piem-am-patch-attachment-p
+                                      (plist-get part :content-type))
                                      (plist-get part :content)))
                               (plist-get body :content)))))
            (when patches
diff --git a/piem.el b/piem.el
index 784d0b3..9cc6a88 100644
--- a/piem.el
+++ b/piem.el
@@ -561,6 +561,11 @@ (defun piem-inject-thread-into-maildir (mid &optional message-only)
 ;;;; Patch handling
+(defun piem-am-patch-attachment-p (type)
+  "Return non-nil if an attachment should be treated as a patch.
+TYPE is a media type such as \"text/x-patch\"."
+  (member type '("text/x-diff" "text/x-patch")))
 (defun piem-extract-mbox-info (&optional buffer)
   "Collect information from message in BUFFER.
 If BUFFER is nil, the current buffer is used.  Any message after

  parent reply	other threads:[~2020-11-22 20:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-22 20:46 [PATCH 0/4] Support text/plain patch attachments Kyle Meyer
2020-11-22 20:46 ` [PATCH 1/4] gnus: Prefer mm-handle-media-type over direct access Kyle Meyer
2020-11-22 20:46 ` Kyle Meyer [this message]
2020-11-22 20:46 ` [PATCH 3/4] Use when-let in a few more spots Kyle Meyer
2020-11-22 20:46 ` [PATCH 4/4] gnus, notmuch: Consider text/plain patch attachments Kyle Meyer
2020-11-22 21:10   ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://git.kyleam.com/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201122204609.12604-3-kyle@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=piem@inbox.kyleam.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).